Skip to content

[compiler-rt] Include missing headers for libFuzzer #146828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 10, 2025
Merged

Conversation

atetubou
Copy link
Contributor

@atetubou atetubou commented Jul 3, 2025

@llvmbot
Copy link
Member

llvmbot commented Jul 3, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Takuto Ikuta (atetubou)

Changes

This is to fix modules build error in chromium like
https://ci.chromium.org/ui/p/chromium/builders/try/linux-libfuzzer-asan-rel/2292144/overview


Full diff: https://github.com/llvm/llvm-project/pull/146828.diff

1 Files Affected:

  • (modified) compiler-rt/lib/fuzzer/FuzzerDriver.cpp (+1)
diff --git a/compiler-rt/lib/fuzzer/FuzzerDriver.cpp b/compiler-rt/lib/fuzzer/FuzzerDriver.cpp
index 3771abf5f532d..734cf28b4e4ac 100644
--- a/compiler-rt/lib/fuzzer/FuzzerDriver.cpp
+++ b/compiler-rt/lib/fuzzer/FuzzerDriver.cpp
@@ -24,6 +24,7 @@
 #include <chrono>
 #include <cstdlib>
 #include <cstring>
+#include <functional>
 #include <mutex>
 #include <string>
 #include <thread>

Copy link

github-actions bot commented Jul 3, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@atetubou atetubou changed the title [compiler-rt] Include <functional> in FuzzerDriver.cpp for std::ref. [compiler-rt] Include missing headers for libfuzzer Jul 3, 2025
@atetubou atetubou changed the title [compiler-rt] Include missing headers for libfuzzer [compiler-rt] Include missing headers for libFuzzer Jul 3, 2025
atetubou and others added 3 commits July 4, 2025 11:53
Co-authored-by: Petr Hosek <phosek@google.com>
Co-authored-by: Petr Hosek <phosek@google.com>
@atetubou
Copy link
Contributor Author

atetubou commented Jul 4, 2025

I applied suggested changes.

@atetubou atetubou requested a review from petrhosek July 8, 2025 04:40
@atetubou
Copy link
Contributor Author

atetubou commented Jul 9, 2025

@petrhosek ping?

Copy link
Collaborator

@zmodem zmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zmodem zmodem merged commit f7cdff7 into llvm:main Jul 10, 2025
9 checks passed
@atetubou atetubou deleted the patch-3 branch July 10, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants